Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requiring PNG for iOS #1793

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Remove requiring PNG for iOS #1793

merged 2 commits into from
Sep 20, 2024

Conversation

mpivchev
Copy link
Contributor

PNGs sent are low quality, and iOS supports SVGs being sent.

@artonge
Copy link
Collaborator

artonge commented Sep 19, 2024

/backport to stable30

@artonge
Copy link
Collaborator

artonge commented Sep 19, 2024

/backport to stable29

@artonge
Copy link
Collaborator

artonge commented Sep 19, 2024

/backport to stable28

Copy link

cypress bot commented Sep 19, 2024

Activity    Run #1971

Run Properties:  status check passed Passed #1971  •  git commit ce2efca11e: Remove requiring PNG for iOS
Project Activity
Branch Review require-png-ios
Run status status check passed Passed #1971
Run duration 05m 20s
Commit git commit ce2efca11e: Remove requiring PNG for iOS
Committer Milen Pivchev
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10
View all changes introduced in this branch ↗︎

@artonge
Copy link
Collaborator

artonge commented Sep 20, 2024

@mpivchev please fix DCO

mpivchev and others added 2 commits September 20, 2024 11:25
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@artonge artonge merged commit f438f56 into master Sep 20, 2024
50 checks passed
@artonge artonge deleted the require-png-ios branch September 20, 2024 10:28
@artonge
Copy link
Collaborator

artonge commented Sep 20, 2024

/backport 7b7d464 to stable30

@artonge
Copy link
Collaborator

artonge commented Sep 20, 2024

/backport 7b7d464 to stable29

@artonge
Copy link
Collaborator

artonge commented Sep 20, 2024

/backport 7b7d464 to stable28

Copy link

backportbot bot commented Sep 20, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/1793/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7b7d4645

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1793/stable30

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/1793/stable30."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Sep 20, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/1793/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7b7d4645

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1793/stable29

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/1793/stable29."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Sep 20, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/1793/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7b7d4645

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1793/stable28

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/1793/stable28."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants